Tyler Van Gorder

Results 51 comments of Tyler Van Gorder

This could actually be quite tricky to implement when encountered. What would the remediation strategy be? Look for an accessor? This might be best as a search recipe.

This may be a bit tricky, but the sonar implementation will provide hints: https://github.com/SonarSource/sonar-java/blob/master/java-checks/src/main/java/org/sonar/java/checks/tests/ParameterizedTestCheck.java

I think this should be sufficient for now.

The task should ONLY add the configuration when the pom is generating a fat/executable jar/war.

I think maybe we could predicate this on if the `java.version` property exists in the resolved Maven model. If `java.version` exists and `java.version` is less than the desired value, either...

Good point, I think we would only want to add the `java.version` to poms where the parent is either not present or not also in the list of source files....

Yeah, I think we can just define tasks in this issue to organize the work. We used the "one recipe per method" in the AssertJ migrations: https://github.com/openrewrite/rewrite-testing-frameworks/tree/main/src/main/java/org/openrewrite/java/testing/assertj I think you...

@rdifrango We have a similar (much more broad issue) in rewrite-migrate-java. I am going to move this issue to that repo. Thanks for reporting.