skosjs icon indicating copy to clipboard operation
skosjs copied to clipboard

Invalid SPARQL query in SKOS client

Open jaw111 opened this issue 12 years ago • 4 comments

The query to create a new concept is not valid as it contains an empty WHERE {} clause. Previously this was WHERE { ?s ?p ?o }.

Locally I modified the query to INSERT DATA in line the the query to create a top concept.

jaw111 avatar Jun 27 '13 10:06 jaw111

Great stuff!

Can you send me a patch for this, would be nice to merge your local fixes back!

Best Regards Thomas

tkurz avatar Jun 27 '13 12:06 tkurz

Hi Thomas, What is the best method to do this, to be honest I'm still just getting started with Git and Github. John

Date: Thu, 27 Jun 2013 05:33:43 -0700 From: [email protected] To: [email protected] CC: [email protected] Subject: Re: [skosjs] Invalid SPARQL query in SKOS client (#24)

Great stuff!

Can you send me a patch for this, would be nice to merge your local fixes back!

Best Regards

Thomas

— Reply to this email directly or view it on GitHub.

jaw111 avatar Jun 29 '13 09:06 jaw111

Hi John

actually it is quite simple. Create the patch and append it to the issue. The command for it is git-format-patch

Here is a short description. https://openhatch.org/wiki/How_to_generate_patches_with_git_format-patch

That is maybe the easiest way.

Thx in advance! Thomas

Am 29.06.2013 um 11:36 schrieb jaw111 [email protected]:

Hi Thomas, What is the best method to do this, to be honest I'm still just getting started with Git and Github. John

Date: Thu, 27 Jun 2013 05:33:43 -0700 From: [email protected] To: [email protected] CC: [email protected] Subject: Re: [skosjs] Invalid SPARQL query in SKOS client (#24)

Great stuff!

Can you send me a patch for this, would be nice to merge your local fixes back!

Best Regards

Thomas

— Reply to this email directly or view it on GitHub. — Reply to this email directly or view it on GitHub.


Thomas Kurz Knowledge and Media Technologies Salzburg Research Tel: +43/622/2288-253

tkurz avatar Jun 30 '13 21:06 tkurz

Hi John,

can you send me a pull request to your fork. This would be the easiest way to integrate your patch into the current master. It is described here: https://help.github.com/articles/using-pull-requests

Regards Thomas

tkurz avatar Oct 03 '13 12:10 tkurz