Support for tox 4

[ryshoooo]

Updated the source code to support tox >= 4.0.0. The old implementation is kept for old tox versions.

Closes #15

[jamwil]

Thanks for this @ryshoooo! Is this good to go @tkukushkin? Can we merge and release?

[bcyran]

Hey @tkukushkin. I do realize you said you don't really have time for development but I would appreciate if you considered merging and releasing this since @ryshoooo took the time to make it work.

[jamwil]

Hey @tkukushkin. I do realize you said you don't really have time for development but I would appreciate if you considered merging and releasing this since @ryshoooo took the time to make it work.

Or alternatively make one of the participants on this PR a maintainer so we can merge this and coordinate moving repo ownership under the tox-dev umbrella.

[tkukushkin]

Hello @ryshoooo, @bcyran, @jamwil. I have reviewed this pull request and have tested latest version of poetry with tox.

On one of my projects with 144 dependencies when all packages are already installed poetry install spends only 1 second to check that everything is ok.

Previously, I saw the value of this plugin in fact, that with this plugin tox runs poetry install only when it creates new virtual environment, because poetry install was really slow even when all packages are installed, so I had to wait it every tox execution, it was just waste of time. Now, I don't see such problem with latest poetry version anymore. So personally I don't see any value in this plugin anymore. Examples from poetry documentations work fine.

But I understand that I may not understand your use cases and you may see some another value in this plugin, I will be glad if you describe it.

[bcyran]

I checked it with my projects and I have to admit everything works like @tkukushkin described. I think in my use case the plugin isn't needed anymore indeed.

[jamwil]

I agree it's not strictly necessary and its use in new projects should be discouraged, but in the interest of preserving existing workflows there may be some value in tov v4 support. I'm not sure how widely this is used—I'm happy to update the one repository of my own that uses it currently, but if this issue is more widespread then perhaps a patch and deprecation is logical?

[ryshoooo]

Hello @ryshoooo, @bcyran, @jamwil. I have reviewed this pull request and have tested latest version of poetry with tox.

On one of my projects with 144 dependencies when all packages are already installed poetry install spends only 1 second to check that everything is ok.

Previously, I saw the value of this plugin in fact, that with this plugin tox runs poetry install only when it creates new virtual environment, because poetry install was really slow even when all packages are installed, so I had to wait it every tox execution, it was just waste of time. Now, I don't see such problem with latest poetry version anymore. So personally I don't see any value in this plugin anymore. Examples from poetry documentations work fine.

But I understand that I may not understand your use cases and you may see some another value in this plugin, I will be glad if you describe it.

Fair point @tkukushkin :) I've tested it out as well, and indeed this plugin is not necessary. I'll leave the PR open and let you decide whether to close it or merge it, but I'll personally stop using the plugin going forward :)