react-form-with-constraints icon indicating copy to clipboard operation
react-form-with-constraints copied to clipboard

Replace console.assert() with Facebook's invariant

Open tkrotoff opened this issue 6 years ago • 3 comments

See https://github.com/zertosh/invariant See https://github.com/facebook/fbjs/blob/c69904a511b900266935168223063dd8772dfc40/packages/fbjs/src/forks/invariant.js

tkrotoff avatar Oct 31 '17 02:10 tkrotoff

See https://github.com/BerkeleyTrue/warning, used by Material-UI: https://david-dm.org/mui-org/material-ui?path=packages%2Fmaterial-ui

tkrotoff avatar Feb 06 '19 23:02 tkrotoff

The real issue is here: https://github.com/tkrotoff/react-form-with-constraints/blob/v0.12.0/packages/react-form-with-constraints/src/FormWithConstraints.tsx#L113

The console.assert() here can make user tests fail.

tkrotoff avatar Jun 17 '19 13:06 tkrotoff

See 340db7341bf25fb5b7ff987b81c2e9fb006200d7, packaged with v0.13.0

tkrotoff avatar Mar 10 '20 00:03 tkrotoff