linenote icon indicating copy to clipboard operation
linenote copied to clipboard

comments are bound to location of code instead of code itself.

Open Dinesh-AR opened this issue 6 years ago • 9 comments
trafficstars

For example, when I add comment to line 10 and later if add couple of line before line 10. The comment is applied to newly added code which is present in location line 10.

Dinesh-AR avatar Mar 25 '19 10:03 Dinesh-AR

Thank you for your comment. As you say, it is good to add an option to shift the position of notes on editing. ~~This is a simple extension, so it may not have enough features...~~ [Edit]: Obviously it would be useful to have it. This feature should be added.

tkrkt avatar Mar 25 '19 15:03 tkrkt

I second this feature. This would definitely be handy. This is implemented in this extension, you could check it out

FatehAK avatar May 08 '19 21:05 FatehAK

This is definitely a good feature to have, it's annoying to lose (as in can't find them) your notes because you're moving code around.

HoldYourWaffle avatar Aug 24 '19 21:08 HoldYourWaffle

Please add this feature, without it the whole extension doesnt make sense. In which state of progress is the work on this?

PeterBenc avatar Sep 06 '19 14:09 PeterBenc

I also would like to say this is a feature I'd love to see added. In addition I want to say THANK YOU!! for this extension! I was wanting the ability to have inline notes as a feature in VS Code and then decided to search to see if someone else had done it and sure enough your extension already existed with great features! If you have time and develop this further the ability to have the notes move with the original line they are applied to would be nice as well as the notes updating their references if a file is renamed. Currently when renaming a file the notes disappear and if a new file is created with the original file's name the notes become associated with that new file.

With that said, even if these features aren't added I just want to say thanks again the plugin as it has been nice to use.

Thanks!

andywhitaker avatar Oct 15 '19 15:10 andywhitaker

Thanks for the plugin! This is a feature most people would like. If you're happy to support this, I could look into it and issue a PR - a working draft we can refine. Let me know 😊

ohansemmanuel avatar Feb 17 '20 10:02 ohansemmanuel

PR is very helpful! 😄

tkrkt avatar Feb 21 '20 01:02 tkrkt

For example, when I add comment to line 10 and later if add couple of line before line 10. The comment is applied to newly added code which is present in location line 10.

Note sure if you're still interested in the use case, but I implemented that functionality here: https://marketplace.visualstudio.com/items?itemName=prmichaelsen.linenoteplus

prmichaelsen avatar Sep 09 '23 20:09 prmichaelsen

I don't think adding functionality to auto shift notes when a user edits the file is practical, especially in a multi-user environment where multiple users are modifying both the code and the notes and then checking code into GIT. The merging would be a nightmare. @prmichaelsen has the right design approach with his fork extension "Line Note Plus" but the project is too buggy and I really think it needs an option to be able to hide all of the comment links that his approach requires to reduce the visual noise.

dokmanc avatar Sep 29 '23 15:09 dokmanc