Tibor Kotosz

Fix issue when login is not recorded for updated admin user

1

### Description (*) When an admin user is updated through the Magento admin then the `reload_acl_flag` is set to 1. Because of this during the next login of this admin...

[RPC][import_class] Import class command tries to find "(" class

1

When I execute the `import_class` command while the cursor is right before the class name (e.g. `__construct(MyClass $myClass)`) then it tries to find the classes named `(` and fails. This...

[RPC][transform] Convert transform sub-commands to first-class commands

1

Possible sub-commands of `transform` at the moment: - complete_constructor - add_missing_properties - fix_namespace_class_name - implement_contracts I think it would be good to convert these "sub-command" to "first-class" commands because: -...

[RPC][extract_expression] Extract expression without selection potentially breaks the code

1

Currently if `extract_expression` executed while nothing is selected (offset start = offset end) then it potentially breaks the code. (well surprisingly sometimes it figures out what to do anyway -...

Most of the RPC commands take the following arguments: - `path`: The current file path - `source`: The current file source - `offset`: The current cursor position as byte offset...

[RPC] Guess the language based on the given file

4

Currently it seems a `language` parameter need to be passed over to some commands to make it work with non-php files (e.g. gherkin feature files) otherwise phpactor seem to default...

[RPC][documentation] Missing documentation for "language" parameter

3

It seems some commands like `goto_definition` has a language parameter which need to be provided otherwise it defaults to php. For example this is needed for the [behat-extension](https://github.com/phpactor/behat-extension) otherwise it...

[RPC][transform][complete_constructor] Missing new line between generated properties

2

After executing `transform: complete constructor` command the result looks like this:  It is missing a new line between the first and second property. (Note: I am using a custom...

[RPC][transform][add_missing_properties] Class aliases are ignored by add_missing_properties

1

When running `transform:add_missing_properties` the properties are added but the generated docblock always refers the short name of the class and it is ignoring the aliases. E.g.: after add missing properties:...

In the documentation `Class Expand` mentioned as a feature but actually this command does exists. (RPC documentation is correctly not mentioning it) I have checked the VIM plugin to see...