Ted Kolovos

Results 120 comments of Ted Kolovos

I moved this to the backlog and made it blocked until the completion of #1330 since only then will we have a revised list of privileged roles which will determine...

I added issues that I felt were related to this epic in the description above. Please review. We should probably set a priority order to work the respective issues.

@schrolla @mitchelbaker-cisa @dagarwal-mitre I performed a detailed re-review of the issues still open associated with this epic and here are my suggestions: - Issues #1170 and #1323 should be worked...

A placed this as high priority since the tool can incorrectly produce a Pass when the user has configured the types of exclusions described in this issue, therefore bypassing the...

> Review against epic #754 to see if these conditions should be included in that epic. I added it.

### Scope refinement This comment slightly modifies the original requirements and adds more context by providing screenshots of the conditional access admin portal for reference. The following requirements are updated:...

### Final scope change The implemented changes in the PR vary slightly from the most recent scope definition. The code now prohibits role exclusions and application exclusions. We are not...

Related: https://github.com/cisagov/ScubaGear/issues/979 https://github.com/cisagov/ScubaGear/pull/1145

### No licenses This [previous pull request contains a comment](https://github.com/cisagov/ScubaGear/pull/1145#issuecomment-2302631082) with some sample code that might help prototype and develop the solution for the "no license" scenario for brand new...