ns3-gym icon indicating copy to clipboard operation
ns3-gym copied to clipboard

flexible source dir

Open rukyr97 opened this issue 2 years ago • 2 comments

With this patch, users no longer need to move the full ns3-gym repo into the contrib folder of ns-3. Instead, they can use symbolic links. This wasn't possible without this patch because the code was dependent of the output of os.getcwd(). Herein, the default behavior remains the same. However, we can specify with the optional source_dir parameter, what is the working directory that we want to define as the source directory.

rukyr97 avatar Oct 14 '22 15:10 rukyr97

Thank you for explanation. Indeed, might be a nice feature for some users. Could you clean the commit history and provide only 1 commit with the feature? The two first commits are already in main repo, so just the code allowing to set the src dir.

pgawlowicz avatar May 09 '23 18:05 pgawlowicz

It is done :)

rukyr97 avatar May 18 '23 09:05 rukyr97