Tobias Klauser

Results 147 comments of Tobias Klauser

It also looks like the PR branch needs a rebase.

I think #166 should fix this issue, at least when building `gops` using Go 1.18. @pcj could you please check whether `gops` v0.3.23 built using Go 1.18 works as expected...

I've tested this with the following combinations using `examples/hello` as the agent: 1. new agent, new `gops` binary: `gops trace 10s` -> works as expected 2. new agent, old `gops`...

> Hit the data race in tests, need to figure out if this is something about this PR that triggered it These should be fixed by #174

Looks like this needs a rebase now that #174 is merged.

Thanks for your PR. Why does PVS-Studio only complain about these two specific instances? There are other comparisons of `len < 0` in the same function which also don't have...

Thanks for providing the full report. In that case I really think the check for `len < 0` is unnecessary, because of the check for `len == sizeof(struct icmpv6_neighb_disc_ops_type_17_1)` and...

Sure. Feel free to submit whenever you like... Thank you!

Thanks. Could you please squash your commits and correct the commit message (e.g. using `git commit --amend`)? Also, the commit message should be prefixed with something like `dissectors:' (since it...