Thomas Kittelmann

Results 39 comments of Thomas Kittelmann

Or maybe the `ase.exe` is invoking the `ase-script` file lying next to it.

Yes, and then presumably the ase-script is the actual python script. It all looks good to me, the pip people did the necessary hacks :-) So it is just a...

Btw., the ncrystal installation in question - is it done manually via CMake? In that case there won't be any pip/conda magic and we might in any case need .bat...

Perfect, I should hopefully get around to this in "a few weeks".

Hmm... I guess for now I would prefer if you update the logic in `MCPL_input`, since I have a feeling that I wan't to give the MCPL code itself a...

@marquezj it looks fine to me. Once we hopefully have some even better NCrystal documentation, we can go back to the openmc documentation and see if we need to update...

So the tests are unsurprisingly failing with: ``` import NCrystal ModuleNotFoundError: No module named 'NCrystal' ``` @paulromano could you kindly suggest where you would like changes, to enable NCrystal being...

@paulromano : Is it normal that some of the checks do not start? All the started ones have now passed. Are there any remaining things we need to look at,...

Thanks @paulromano , all changes committed as requested. Anything else? Let me know if you want me to do a rebase of the branch on main now, or do any...

Hi @paulromano Despite the status saying "1 change requested", I think we did everything. Let us know if you think more is needed :smile: Cheers, Thomas