holen icon indicating copy to clipboard operation
holen copied to clipboard

Suggestion: rename `fetch` key within render prop

Open jamesplease opened this issue 7 years ago • 2 comments

The fetch method within the render prop shadows globalScope.fetch, which isn't ideal. Although it is nice that it has the same name, it could potentially cause confusion in certain situations.

One idea would be to rename it so as to avoid this problem.

Just a thought. No worries if you're satisfied with the current name :v:

Thanks for reading!

jamesplease avatar Jan 21 '18 19:01 jamesplease

This makes sense. I think something simple like doFetch or similar should work for now.

tkh44 avatar Jan 22 '18 17:01 tkh44

:+1: Cool. I'll make a PR. Thanks @tkh44 !

jamesplease avatar Jan 22 '18 17:01 jamesplease