BenchmarkCI.jl icon indicating copy to clipboard operation
BenchmarkCI.jl copied to clipboard

Inplace comment update

Open tkf opened this issue 5 years ago • 2 comments

@aviatesk composed a solution to update comment in place:

https://github.com/aviatesk/JET.jl/blob/8a458dd8d675c8e26c1149517c8dfbb1d755f01b/.github/workflows/benchmark.yml#L28-L68

Quoting my comment on slack:

I moved to git repository-based output (https://github.com/tkf/BenchmarkCI.jl#store-benchmark-result-in-a-git-branch-optional-very-experimental) so I'm not personally annoyed by the comment spamming anymore. But this is a bit more involved to set up so "inplace" comment updating like yours is a really nice default. I think it should be possible to write up GitHub API-based solution in BenchmarkCI. But I wonder if it is better to just provide the set of actions you wrote up as a composite action? https://docs.github.com/en/free-pro-team@latest/actions/creating-actions/creating-a-composite-run-steps-action

tkf avatar Dec 14 '20 02:12 tkf

@aviatesk solution should be applicable for any package right?

theogf avatar Feb 01 '22 14:02 theogf

yes

aviatesk avatar Feb 01 '22 14:02 aviatesk