aiopyarr icon indicating copy to clipboard operation
aiopyarr copied to clipboard

Fix regexp url #70

Open DidierMetral opened this issue 1 year ago • 2 comments

Add dash and uppercase in url regexp

Proposed change

Add the possibility to use all allowed chars in standard URL (lowercase, uppercase, digits, dot and dash)

Type of change

  • [ ] Dependency upgrade
  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (which adds functionality)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #70
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass.
  • [x] There is no commented out code in this PR.
  • [x] The code has been formatted (make lint)
  • [ ] Tests have been added to verify that the new code works.

DidierMetral avatar Oct 11 '24 22:10 DidierMetral

Can a maintainer review this fix (ping @tkdrob)? The workflow is awaiting approval from a maintainer.

DidierMetral avatar Oct 24 '24 13:10 DidierMetral

Any way we can help get this through? I am hitting this and unable to change my DNS as the provider I use now makes it required

jim-edwards avatar Jul 27 '25 23:07 jim-edwards