ForwardThinking icon indicating copy to clipboard operation
ForwardThinking copied to clipboard

Issues in structure.py and FTDRF_test.py?

Open EcoSimIBM opened this issue 7 years ago • 2 comments

Hey there,

I tried running the Deep RF and DNN code. I got the DNN code working no problem, but the Deep RF code apparently has a couple issues. In FTDRF_test.py ("y_sp = y_sp.astype('uint8')") seems to fail as y_sp was not yet initialized. After commenting that out (it doesn't appear to be used at all), it then fails in structure.py at the line "for tree in models[count].estimators_: # make half of the trees completely random Decision Trees" - similar issue (I think) - to me it appears as though the trees have not been generated yet and thus the forest has no attribute "estimators_" (the error generated is an AttributeError when trying to iterator over the "esimators_" attribute in the RandomForestClassifier).

Is there something I'm missing here?

Thanks,

Ryan

EcoSimIBM avatar Dec 22 '17 22:12 EcoSimIBM

Hi Ryan,

Pardon the slow reply. I found the bug in the code and updated it. The update should be merged back into the repo by the end of the week.

Thanks, David

davidkartchner avatar Jan 17 '18 20:01 davidkartchner

Hello David,

No worries. Sounds good.

Thanks,

Ryan

On Wed, Jan 17, 2018 at 3:35 PM, David Kartchner [email protected] wrote:

Hi Ryan,

Pardon the slow reply. I found the bug in the code and updated it. The update should be merged back into the repo by the end of the week.

Thanks, David

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tkchris93/ForwardThinking/issues/6#issuecomment-358436366, or mute the thread https://github.com/notifications/unsubscribe-auth/AfDUj40NjkGdd1qBHpwWnw8ct5tsjI4Wks5tLll1gaJpZM4RLdkA .

EcoSimIBM avatar Jan 17 '18 21:01 EcoSimIBM