pysubs2 icon indicating copy to clipboard operation
pysubs2 copied to clipboard

Add timestamps class v2

Open moi15moi opened this issue 2 years ago • 6 comments

This pull request will implement #57. Is also overwrite this PR #65.

Important to note, I haven't been able to get the information if the microdvd end frame value is inclued or not. Aegisub consider it like inclued, so I decided to do like them. Edit (2023-04-29): I test with ffmpeg. It also inclued the end_frame. Because of that, I needed to change the value of some tests.

moi15moi avatar Mar 26 '23 21:03 moi15moi

Hi @moi15moi, do you plan to add more commits or is this ready to merge? :)

tkarabela avatar Apr 02 '23 15:04 tkarabela

It would be ready except if you find that the end_time of the microdvd is exclued.

Also, you may wanna see how the shift method is currently done.

moi15moi avatar Apr 02 '23 15:04 moi15moi

Ok :) I will look at the code when I have time and merge it.

tkarabela avatar Apr 02 '23 15:04 tkarabela

Ok :) I will look at the code when I have time and merge it.

Hi, would you check it soon?

moi15moi avatar Jun 16 '23 20:06 moi15moi

Hi, here is a little bump to know if you will be able to review the PR soon

moi15moi avatar Sep 14 '23 21:09 moi15moi