Tom Kaitchuck

Results 134 comments of Tom Kaitchuck

https://github.com/pravega/pravega/actions/runs/6153432763/job/16697365931?pr=7230

@camsteffen You can see my benchmarks of just the hasher here: https://github.com/tkaitchuck/aHash/blob/master/compare/readme.md#speed There is also some more qualitative comparison on that same page if you scroll up. FNV is only...

@St4NNi Truncation should be fine, as both the upper and lower 32bits of the output are of high quality.

@RaulGracia Note the `@RunWith(SerializedClassRunner.class)` at the top of the file. It shouldn't be run in parallel with any other standalone tests. If it is (say because that test doesn't use...

https://github.com/pravega/pravega/actions/runs/6153432763/job/16697366066?pr=7230

An example stack trace: ``` java.lang.IllegalArgumentException: length must be a non-negative number and greater than startOffset. at com.google.common.base.Preconditions.checkArgument(Preconditions.java:142) at io.pravega.segmentstore.contracts.StreamSegmentInformation.(StreamSegmentInformation.java:78) at io.pravega.segmentstore.contracts.StreamSegmentInformation$StreamSegmentInformationBuilder.build(StreamSegmentInformation.java:74) at io.pravega.segmentstore.server.containers.StreamSegmentMetadata.getSnapshot(StreamSegmentMetadata.java:377) at io.pravega.segmentstore.server.containers.MetadataStore.getSegmentSnapshot(MetadataStore.java:315) at io.pravega.segmentstore.server.containers.MetadataStore.getSegmentInfo(MetadataStore.java:284) at io.pravega.segmentstore.server.containers.StreamSegmentContainer.getStreamSegmentInfo(StreamSegmentContainer.java:512)...

This is caused by a race condition due to a bug in segment store's design. In `SegmentMetadataUpdateTransaction` there is a method `apply` which applies the relevant updates to the `UpdateableSegmentMetadata`...

May I suggest assigning each language a color from the the [github language colors](https://github.com/ozh/github-colors) list.

It is also visible as a numeric value on this page: https://juliahub.com/ui/Packages

When this PR merges into the standard library, we will be able to remove the length prefixing: https://github.com/rust-lang/rust/issues/96762 Until then any hasher which does not work the way that sip-hash...