aHash icon indicating copy to clipboard operation
aHash copied to clipboard

0.8.12 bumps getrandom to 0.3, breaking code

Open schungx opened this issue 8 months ago • 6 comments

getrandom 0.3 breaks existing code due to changed js treatment.

ahash should not bump getrandom unless it bumps to 0.9.

schungx avatar May 13 '25 03:05 schungx

This issue is essentially the same as https://github.com/tkaitchuck/aHash/issues/276

schungx avatar Aug 15 '25 07:08 schungx

Can we resolve this issue? Bumping getrandom to v3 is breaking. It is very frustrating and should probably be gated under a feature or bumping at least the minor version to 0.9.

schungx avatar Oct 13 '25 17:10 schungx

@schungx it seems that getrandom is close to providing a proper solution: https://github.com/rust-random/getrandom/pull/730

Also waiting for a proper fix in a new release..

mahlquistj avatar Oct 13 '25 20:10 mahlquistj

The issue is that the new version of getrandom doesn't seem to support stdweb... although I understand that stdweb is deprecated, still it'll break old code.

Also the new version seems to require elaborate setup to build for WASM, something to add to RUSTFLAGS etc. Not everybody wants that... they'd be happy with the old getrandom.

schungx avatar Oct 13 '25 21:10 schungx

Agreed. I would be happy with the old one too..

mahlquistj avatar Oct 14 '25 07:10 mahlquistj

I am wondering if this issue will be addressed. Bumping getrandom to 0.3 should technically be breaking, necessitating a major version bump.

schungx avatar Nov 21 '25 02:11 schungx