aHash icon indicating copy to clipboard operation
aHash copied to clipboard

Undeclared features

Open mitsuhiko opened this issue 11 months ago • 2 comments

I was compiling the crate locally to try to investigate some internal changes, and I noticed that the crate checks a bunch of undeclared features. Specifically I get a lot of warnings for these features:

  • folded_multiply
  • specialize

Additionally I get warnings for unknown target_pointer_width = "128" and fuzzing. I'm assuming all of this is intentional, but I'm confused about how in particular the features are turned on. Is that code where one has to temporarily add these features to the Cargo.toml?

I'm mostly trying to figure out how to test all of this if I make changes.

mitsuhiko avatar Feb 05 '25 17:02 mitsuhiko

Take a look at https://github.com/tkaitchuck/aHash/blob/master/build.rs Those are autodetected features. The existing presubmit tests in github cover all those cases. So a normal PR should cover all needed code.

tkaitchuck avatar Apr 24 '25 23:04 tkaitchuck

The folded_multiply and specialize cases are addressed in #269.

briansmith avatar May 05 '25 20:05 briansmith