specification-arg-resolver icon indicating copy to clipboard operation
specification-arg-resolver copied to clipboard

Accept multiple @Spec for the same @Join alias

Open thesivis opened this issue 4 years ago • 3 comments

When we have this code, a query with two joins was build

@Join(path = "sub", alias = "sub") ...

@And({ @Spec(path = "sub.attribute1", params = "att1", spec = Equal.class), @Spec(path = "sub.attribute2", params = "att2", spec = Equal.class),})

The generated SQL was like

inner join sub sub0 ..... inner join sub sub1 ..... where sub0.attribute1 = ? and sub1.attribute2 = ?

thesivis avatar Feb 24 '21 21:02 thesivis

Please @thesivis review this pull request. Your solution is not integrated to master yet. I have this problem and it would be wonderfull if it could be solved. Thanks in advance.

mariseltm avatar Aug 25 '22 14:08 mariseltm

@mariseltm I integrated my solution with master now. Can you verify please?

thesivis avatar Aug 29 '22 14:08 thesivis

@tkaczmarzyk please merge this

wicaksono avatar Sep 02 '22 07:09 wicaksono

@thesivis @wicaksono @tkaczmarzyk Are these changes already integrated with master? What version number do I have to set in my pom to use the updated library?

mariseltm avatar Sep 23 '22 17:09 mariseltm

@wicaksono @mariseltm Merged to master and will be released with 2.9.0 today.

tkaczmarzyk avatar Nov 24 '22 08:11 tkaczmarzyk

v2.9.0 has been released and is now available in Maven Central

tkaczmarzyk avatar Nov 24 '22 12:11 tkaczmarzyk