Tom Kwong

The types/functions generated by the macro should be documented.

Timestamp data should be more precise

1

This code could be improved as x[i] is a floating point value of # of seconds since epoch. By multiplying it by 1e3 or 1e6 would allow us to read...

Missing data from first META page

4

It seems that data residing the in the first META page is missing. I guess it might be introduced in the last major refactoring. Examples: #### data_pandas/test2.sas7bdat ``` julia> readsas("data_pandas/test2.sas7bdat")...

Accessors for SASLib handler object

2

When reading a file incrementally, the `open` function returns a SASLib.Handler object. Honestly, this struct is somewhat heavy and and probably not very well designed. From a data encapsulation perspective,...

SAS7BDAT stores all numbers as floating point values. When a value is missing, it stores the number as `NaN`. Technically, `NaN` and missing data are different things but in this...

Remove unnecessary comments Constants should be in upper cases Private functions with leading underscore (?) Use underscore to separate multi-word functions consistently (?)

Integrate with FileIO

2

See https://github.com/JuliaIO/FileIO.jl

Any way to keep the original source clean?

7

Let's say I have a function that looks like this: ```julia function do_something_useful(a, b, c) d = @mock(first_part(a, b)) if @mock(second_part(c, d)) @mock(third_part()) else @mock(forth_part()) end end ``` As you...

Support DocStringExtensions

18

Ideally the DocStringExtensions variables are expanded automatically and markdown format is respected. The Julia REPL can handle it properly.