Tim Radvan

Copying this here because I'm not sure if gist comment notifications are a thing: > I’m curious, why did you choose to consume newline tokens when they’re before an indent/dedent?...

@JoshuaGrams Nathan's implementation looks more comprehensive than yours, although I realise it doesn't conform to the Lexer API that Nearley expects. Note that unless you're using Nearley's rewinding features (which...

> which wraps a lexer in another lexer FWIW, we should probably come up with a nicer way for wrapping Moo Lexers. Perhaps just some kind of helper for constructing...

I agree; as I implied in the PR description, it feels weird leaving implicit how strings are handled. I slightly prefer `ignoreCase: true`, because we _can_ compile string literals into...

Do we need the case-folding map, or can we use the `.toUpperCase()` and `.toLowerCase()` built-ins? Sounds like we're agreed about making ignoreCase per-string. I agree it shouldn't be required when...

Is that for `/s/i`, or only `/s/ui`? If the latter, then I think it would be reasonable to only support `{match: "s", ignoreCase: true}` when the unicode flag is not...

I added an ignoreCase option for literals. We don't yet allow it to be used in isolation; that can come in a future PR, so you can write: ``` moo.compile({...

Nice one! Would you like to PR that? (Perhaps unminified?) > I believe it actually is both necessary and sufficient. Nice -- thanks for comprehensively confirming that. Regarding my comment...

I was thinking the same thing. I opened #123, which adds only the unicode flag. Once that's merged, I'll rebase this PR, to keep the conversation about ignoreCase in one...

It appears I answered my own question, two years ago :) https://github.com/tjvr/scratchblocks/issues/58#issuecomment-67953012 > the order of the mathematical infix operators +-*/% is reversed for Arabic -- that must be what...