react-chatbotify icon indicating copy to clipboard operation
react-chatbotify copied to clipboard

[Task] Add unit test cases for useToastsInternal hook

Open tjtanjin opened this issue 1 year ago • 2 comments

Task Description: Currently, we run unit tests using jest which can be found here.

However, the test cases are not yet comprehensive enough and work can be done to cover more grounds. Specifically for this issue, we hope to add test cases for the useToastsInternal hook.

Deliverable(s): New unit test cases that cover the testing of the useToastsInternal hook.

Additional Context:

  • Hooks API can be found here
  • Existing unit test for hooks can be found here which may serve as a good source for reference.

tjtanjin avatar Oct 03 '24 16:10 tjtanjin

I want to give it a try to this one.

manoshatzi avatar Oct 06 '24 07:10 manoshatzi

I want to give it a try to this one.

Go for it!

tjtanjin avatar Oct 06 '24 07:10 tjtanjin

Hey @manoshatzi! Checking in to see if you're facing any problems working on the issue. Feel free to reach out!

tjtanjin avatar Oct 18 '24 17:10 tjtanjin

Hey @manoshatzi! With hacktoberfest drawing closer to the end, I'll be re-opening this issue for others that may be keen in this final stretch. That said, if you're still interested, feel free to open a PR soonest!

tjtanjin avatar Oct 20 '24 16:10 tjtanjin

Hey @tjtanjin. Yes do that. So sorry for not have been finish it but I was really too busy and my spare time was really too less.

manoshatzi avatar Oct 21 '24 09:10 manoshatzi

can you please assign this me? I tried it already. @tjtanjin

anjumnnit avatar Oct 23 '24 19:10 anjumnnit

@tjtanjin can you assign this to me

Nandinibajaj16 avatar Oct 26 '24 10:10 Nandinibajaj16

can you please assign this me? I tried it already. @tjtanjin

Can you please assign this on the basis of fcfs as I have only one PR left for hackotberfest'24 :)...

anjumnnit avatar Oct 26 '24 17:10 anjumnnit

Hey @anjumnnit, I'll assign this issue to you since you requested for it first. I'll keep the PR from @Nandinibajaj16 open in the meantime, in case the issue is left incomplete.

Separately @Nandinibajaj16, I've tagged the PR from you with hacktoberfest-accepted so that your efforts are not wasted. However, as mentioned in the contributing guidelines, the issue should be assigned to you before working on it (FCFS, to avoid conflicts such as this). Hope to seek your understanding!

tjtanjin avatar Oct 27 '24 16:10 tjtanjin

@tjtanjin My bad didn't see the updates on the issue before raising the PR, it's okay :)

Nandinibajaj16 avatar Oct 27 '24 16:10 Nandinibajaj16

Hey @anjumnnit, I'll assign this issue to you since you requested for it first. I'll keep the PR from @Nandinibajaj16 open in the meantime, in case the issue is left incomplete.

Separately @Nandinibajaj16, I've tagged the PR from you with hacktoberfest-accepted so that your efforts are not wasted. However, as mentioned in the contributing guidelines, the issue should be assigned to you before working on it (FCFS, to avoid conflicts such as this). Hope to seek your understanding!

tysm 😿

anjumnnit avatar Oct 28 '24 16:10 anjumnnit