203 Supplement - Rework Process.Exited handler

[RFBomb]

This is a supplement to #203

• Reworks the TryCatch statement provided in 203 by wrapping it into a method call
• This now properly unsubscribes from the process object (resolving another potential memory leak)
• isolates the method variable from the class variable by renaming the class variable, ensuring that the process object is held in reference until such time that the task completes, preventing null reference exceptions due to early disposal of the robocommand while the task is still running.

[zabulus]

LGTM for me

[RFBomb]

What does that mean ??

[PCAssistSoftware]

What does that mean ??

I am assuming he meant Looks Good To Me, but whether that means just looking at the code, or actually testing it as requested I am not sure

[zabulus]

Yeah, review looks good. I'm in process of pushing this to environment. Will keep in touch about results of testing

[RFBomb]

@PCAssistSoftware - As long as this satisfies @zabulus, I'm done with this PR. Merging this should close #203 as well, as it bundles that logic modification in

[PCAssistSoftware]

@RFBomb - okay, no problem at all, will wait for @zabulus to confirm after his testing and get it done for you - thanks

[PCAssistSoftware]

@zabulus - can you please confirm if the work done by @RFBomb in this PR fixes your issues so I can get it merged in?

[zabulus]

@PCAssistSoftware yes, we deployed the fix two weeks ago, and crashes haven't occurred since then.

[PCAssistSoftware]

@zabulus - excellent, thanks for confirming @RFBomb - Just confirming you are happy for me to merge this one?

[RFBomb]

Yes you can merge

[PCAssistSoftware]

All done - is #203 now obsolete or did that need merging too?

[RFBomb]

This supercedes 203, which can be simply closed. Probably make a note during closing that implemented via this one.