simple-youtube-api icon indicating copy to clipboard operation
simple-youtube-api copied to clipboard

src: Convert to TypeScript

Open tjrgg opened this issue 4 years ago • 9 comments

tjrgg avatar Mar 14 '20 00:03 tjrgg

Due to eced661393e570ed74ef7da6e8e4bc97c9e43eb9, I couldn't find a way to import the YouTube class...

import { YouTube, parseURL, Video } from 'simple-youtube-api';

Androz2091 avatar May 11 '20 12:05 Androz2091

I'm also getting the following error when compiling: Capture d’écran 2020-05-11 à 14 05 36 but this can probably be fixed by updating typescript configuration (but I don't know how).

Androz2091 avatar May 11 '20 12:05 Androz2091

Due to eced661, I couldn't find a way to import the YouTube class...

import { YouTube, parseURL, Video } from 'simple-youtube-api';

Fixed with 2e5b963023962c52fe3676255f5c40f13af493e5.

I'm also getting the following error when compiling: Capture d’écran 2020-05-11 à 14 05 36 but this can probably be fixed by updating typescript configuration (but I don't know how).

I'm not getting these compiling errors. Make sure you're using TypeScript 3.8.3 and not 3.7.5.

tjrgg avatar May 15 '20 22:05 tjrgg

I am using TypeScript 3.9.2, and I'm still getting these errors...

Androz2091 avatar May 18 '20 07:05 Androz2091

Capture d’écran 2020-05-18 à 09 50 35

Androz2091 avatar May 18 '20 07:05 Androz2091

@Androz2091 Commit e03022af020e91dd98a8027f1033951f6846992a should resolve those compile errors.

tjrgg avatar May 30 '20 23:05 tjrgg

Any updates on this? I'm happy to contribute if needed.

Hazmi35 avatar Oct 31 '20 21:10 Hazmi35

Has this died? I'm willing to help out too.

newtykip avatar Jul 04 '21 12:07 newtykip

Has this died? I'm willing to help out too.

Not completely, just been busy with other projects. If you'd like to help finish it up, PRs to the next branch are welcome.

tjrgg avatar Jul 04 '21 17:07 tjrgg