Clears display on losing tab focus (running multiple tabs)

[yakovkhalinsky]

Steps to reproduce:

1. Open terminal tab
2. Open second terminal tab in same pane
3. Go back to first terminal tab and run a command
4. Click on second tab, run a command
5. Click back to first tab (contents will be cleared and a single character will be displayed

Running with the following setup: Mac OS X 10.8.5 Shell is fish Atom is version 0.73.0 atom-term is version 0.1.3

[tjmehta]

Yakov, thanks for the great repro steps.
Unfortunately atom’s view api does not emit events when a view is “activated” (tab is clicked), so I have an interval which resizes the pane. Which I thought would fix this problem..
What happens when you resize the window?

Thanks

On Wednesday, March 19, 2014 at 3:26 PM, Yakov Khalinsky wrote:

Steps to reproduce:

1. Open terminal tab
2. Open second terminal tab in same pane
3. Go back to first terminal tab and run a command
4. Click on second tab, run a command
5. Click back to first tab (contents will be cleared and a single character will be displayed

Running with the following setup: Mac OS X 10.8.5 Shell is fish Atom is version 0.73.0 atom-term is version 0.1.3

— Reply to this email directly or view it on GitHub (https://github.com/tjmehta/atom-term/issues/3).

[yakovkhalinsky]

Unfortunately resizing the window doesn't bring back the terminal display :)

Just want to say this is a great package :+1:

I might have a look through the package code at some point and see if I can help out a bit.

[yakovkhalinsky]

Don't know if this gives any more clues, I scrolled up in the window after it is "cleared" and see characters on a single column

[tjmehta]

Interesting, yah I noticed that as well. I think the stream should be paused until the tab is fully visible. That will solve the initial single column issue, but not sure about switching back and forth.. I think I need to stop the pause the resize interval when the tab inactive (in a pane where another tab is active, this would also be dependent on a view:activated event).

Tejesh Mehta

On Wednesday, March 19, 2014 at 3:36 PM, Yakov Khalinsky wrote:

Don't know if this gives any more clues, I scrolled up in the window after it is "cleared" and see characters on a single column

— Reply to this email directly or view it on GitHub (https://github.com/tjmehta/atom-term/issues/3#issuecomment-38116048).

[yakovkhalinsky]

Super useful package BTW :+1: so good to see my console output while running and editing node apps

[tjmehta]

@yakovkhalinsky I pushed some changes to the plugin yesterday. I haven't been able to repro the issue. I think the switching tab issue may be resolved, but probably not the scrolling up issue.

[yakovkhalinsky]

Sorry to take so long to get back to this issue.

I've reinstalled the plug in, unfortunately jshint seems to be interfering with it.

Everytime I click in the terminal window I get Uncaught TypeError: Object #<TermView> has no method 'getUri' with a reference to ~/.atom/packages/atom-jshint/lib/atom-jshint.js:141

[tom-spalding]

I can reproduce the issue by opening term in new pane, starting a new tab (or dragging another tab to pane), and going back to term's tab.

:+1: agree, great package!