101 icon indicating copy to clipboard operation
101 copied to clipboard

CONTRIBUTING.md

Open rstacruz opened this issue 7 years ago • 5 comments

I'd like to know how I can contribute additional functions.

Do I just create a new module? What about updating the readme—is that automatically extracted from module docs?

(Specifically, I'd love a 101/reverse as an immutable version of Array.prototype.reverse :))

rstacruz avatar Aug 25 '16 01:08 rstacruz

Btw: http://ricostacruz.com/til/my-immutable-toolkit :)

rstacruz avatar Aug 25 '16 01:08 rstacruz

I would suggest creating an issue for quick discussion, and then PRing it. Sorry for not having a CONTRIBUTING.md :(. Everything is done manually right now. So you'll just have to modify the readme w/ docs for w.e you ad.

Random side note: I want to add an index to the readme like in object-loops. Also, I definitely want to have the readme index sectioned by immutable methods. In a future breaking release, I would like to rename all immutable methods to be prepended w/ "immutable-" ("immutable-set" versus "put").

tjmehta avatar Aug 25 '16 02:08 tjmehta

In general, map utils fit in great w/ 101. There are typically, more in-depth discussions for more complex utils. Same goes w/ any utils that can be created by a composition. I know you're really active w/ OSS (We've chatted a few times and I've seen you're github activity), so I would love to have a smart person like you help me make these decisions.

tjmehta avatar Aug 25 '16 02:08 tjmehta

I would like to rename all immutable methods to be prepended w/ "immutable-"

:-1: on this: it gives the impression that there are non-immutable methods in 101, which there shouldn't be!

rstacruz avatar Aug 25 '16 03:08 rstacruz

could prepend all mutable methods instead mutable-

tjmehta avatar Aug 25 '16 06:08 tjmehta