modbus4mqtt
modbus4mqtt copied to clipboard
WIP attempt to get serial and RS485 Modbus-RTU working
Testing on a Acrel acr10r-d16te but it is not working yet so please don't merge.
Hello @iconnor! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
- In the file
modbus4mqtt/modbus_interface.py
:
Line 18:121: E501 line too long (151 > 120 characters) Line 130:121: E501 line too long (130 > 120 characters)
Comment last updated at 2021-08-16 03:56:14 UTC
Codecov Report
Merging #35 (6e20a9a) into master (96da28f) will increase coverage by
0.19%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #35 +/- ##
==========================================
+ Coverage 95.83% 96.03% +0.19%
==========================================
Files 6 6
Lines 841 857 +16
==========================================
+ Hits 806 823 +17
+ Misses 35 34 -1
Impacted Files | Coverage Δ | |
---|---|---|
modbus4mqtt/modbus4mqtt.py | 94.50% <100.00%> (ø) |
|
modbus4mqtt/modbus_interface.py | 96.58% <100.00%> (+1.00%) |
:arrow_up: |
tests/test_modbus.py | 97.32% <100.00%> (+2.46%) |
:arrow_up: |
tests/test_mqtt.py | 97.40% <0.00%> (-1.16%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 96da28f...6e20a9a. Read the comment docs.
Still WIP: I am waiting for Acrel to give me the registry map, but if I get an ABB one first, I will post it in the PR
I have the manual but the values are not changing despite energy flow: https://swordandstone-my.sharepoint.com/:b:/g/personal/ianconnor_swordandstone_com_au/ETclJIj1jX1GreQjrtyl88YBzintfvcHlodOC6UyEoOODg?e=eFKsUB so still have some work on this one.