Timo Heister

Results 351 comments of Timo Heister

Menno has been using a newer world builder version. @MFraters can you check if this is still broken with the current master?

@elodie-kendall What would help is having a set of simple(!) examples that currently work or don't work. With that, it would be much easier to find the issue.

In particular: Is a free surface required to see the problem? Or is it related to boundary conditions?

Hi Menno, we ran a couple of defect correction with GMG tests in the last few days and all of them seem to work okay. I might have fixed recently...

I think this is the wrong approach (even though @gassmoeller suggesting looking into UNITY_GROUP): 1. This requires 3.18 making it a lot less useful. 2. If you use UNITY_GROUP, you...

> I also agree that (separately from this pull request) the world builder should become a shared library (although that wont make it compile with unity for now). Worldbuilder should...

Wouldn't it be easy enough to have a 2d and a 3d prm file in the folder? It is fine if the manual only shows the 2d one. That would...

Marine, yes. This is not documented anywhere, but dimension and shared libraries are special and need to be in the main file. This is because this information is needed very...

We are also using "ksh" for output from ASPECT, which doesn't make much sense to me (it will probably try to highlight things like "if" "for" etc.. Is there some...

> would you have a solution? I would do the following: 1. delete all files that are not necessary with ``git rm``, commit 2. run ``make indent``, commit 3. do...