node-addon-layer

node-addon-layer copied to clipboard

External handle is no longer being wrapped in an object for Node 0.11+, how can handle be validated?

2

In using the addonlayer, a handle (shim_ctx_t*) is returned and then passed around to be used in additional calls later. To verify that all the proper values are being passed...

jeffbski

This is a slight rollback of the last rollback, but 0.10.18 fails with HEAD of node-addon-layer. This reverts the relevant parts for 0.10 in the short term until there's time...

tcr

for example `shim_buffer_new_external` may result in an immediate collection, the C++ destructor in the `shim_val_t` may be triggering that.

tjfontaine

With node v0.10.17, ran into a problem where an external being passed back to JS-land was represented there as a number, and when passed back to the addon layer could...

notmatt

Ran into a blatant lie in the following error message: ``` /root/hackathon/ndb/dump.js:4 ndb.runcmd_async(handle, "::status", function(err, data) { console.log("in the ^ TypeError: Argument 2 not of type SHIM_TYPE_FUNCTION at Object. (/root/hackathon/ndb/dump.js:4:5)...

notmatt

It would be neat if this was the pattern, instead of what exists today: ``` C int myaddon_myfunc(shim_ctx_t *ctx, shim_args_t *args) { shim_val_t *string0, *string1; if (!shim_unpack(ctx, args, SHIM_TYPE_STRING, &string0,...

jclulow