ion
ion copied to clipboard
tjcsl
TJ Intranet 3
Currently there is only start date, and this behavior is ambiguous in some situations. The better solution would to have both a start date and an end date and display...
`pycups` can be used for the printing module instead of creating subprocesses Here's an example: This uses `pycups` ``` py import cups def get_printers(): try: conn = cups.Connection() names =...
These methods could likely benefit from refactoring: (ion)peter@bronx ~/ion $ flake8 --max-complexity=20 . ./intranet/apps/eighth/models.py:906:1: C901 'EighthScheduledActivity.add_user' is too complex (30) ./intranet/apps/eighth/views/attendance.py:245:1: C901 'take_attendance_view' is too complex (22) ./intranet/apps/eighth/views/signup.py:20:1: C901 'eighth_signup_view'...
This method keeps throwing exceptions, _probably_ due to some latent race condition. It should most likely be completely rewritten to be more robust and easier to understand.
Unit testing is desperately needed throughout the application. The most critical areas: - apps.eighth.models.EighthScheduledActivity.add_user (add to this list as needed)
Logging in on any device different from the one used last clears the previous token; so you can only get notifications on only your phone or your laptop, for example.
Make sure we're not clearing the cache too much, and likewise make sure we're not failing to clear it when necessary.