translit icon indicating copy to clipboard operation
translit copied to clipboard

"ьЬь" inserted between each character when transliterating back to Russian

Open Stratus3D opened this issue 7 years ago • 4 comments

This commit (997899c68112edce325c8e1ac2768f8e2835ecfc) introduces a bug that causes "ьЬь" to be inserted between each character when transliterating back to Russian. The key with a value of "" is invalid. The key should be "'".

Stratus3D avatar Oct 20 '17 16:10 Stratus3D

This is fixed in https://github.com/euroteamoutreach/translit/pull/1

Stratus3D avatar Oct 20 '17 16:10 Stratus3D

I will be happy to merge this in if you want to open up the pull request. We can version and republish the gem after that.

tjbladez avatar Jan 26 '18 00:01 tjbladez

Do you want my PR to include the rspec tests I wrote?

Stratus3D avatar Jan 26 '18 16:01 Stratus3D

Absolutely, specs value is tremendous and overall I think specs are necessary to guide developer usage. I will convert existing riot specs to rspecs as well as part of that release.

tjbladez avatar Jan 26 '18 16:01 tjbladez