git-azure
git-azure copied to clipboard
Added support for 'env_variables' (raw using a CMD) & Windows Azure affinity group
Fixes issue #53
The support for env variables is done through set_env_var.cmd
on the repo if it exists.
Support for affinityGroup
is handled by git azure config
(the same as other parameters)
NOTE: You should either define serviceLocation or affinityGroup but not both (affinityGroup takes precedence over serviceLocation)
Thanks! A few comments in addition to the comments in the diff:
- we should also add
--affinityGroup
as a command line option togit azure init
. This can be done in src\cli\git-azure.js - we should also store the
affinityGroup
in git config after successful deployment as part of https://github.com/tjanczuk/git-azure/blob/master/src/cli/commands/init.js#L81 - could you also pull & merge against the latest
- sure will add it.
- I think we're already doing that. https://github.com/johnnyhalife/git-azure/blob/master/src/cli/commands/init.js#L92
- Will check, I think we're on edge but will check it.
On Wed, Jun 27, 2012 at 6:12 PM, Tomasz Janczuk < [email protected]
wrote:
Thanks! A few comments in addition to the comments in the diff:
- we should also add
--affinityGroup
as a command line option togit azure init
. This can be done in src\cli\git-azure.js- we should also store the
affinityGroup
in git config after successful deployment as part of https://github.com/tjanczuk/git-azure/blob/master/src/cli/commands/init.js#L81- could you also pull & merge against the latest
Reply to this email directly or view it on GitHub: https://github.com/tjanczuk/git-azure/pull/54#issuecomment-6615604
Great, thanks. Re 2) you are right, I missed it.
From: johnny.halife [[email protected]] Sent: Wednesday, June 27, 2012 2:16 PM To: Tomasz Janczuk Subject: Re: [git-azure] Added support for 'env_variables' (raw using a CMD) & Windows Azure affinity group (#54)
- sure will add it.
- I think we're already doing that. https://github.com/johnnyhalife/git-azure/blob/master/src/cli/commands/init.js#L92
- Will check, I think we're on edge but will check it.
On Wed, Jun 27, 2012 at 6:12 PM, Tomasz Janczuk < [email protected]
wrote:
Thanks! A few comments in addition to the comments in the diff:
- we should also add
--affinityGroup
as a command line option togit azure init
. This can be done in src\cli\git-azure.js- we should also store the
affinityGroup
in git config after successful deployment as part of https://github.com/tjanczuk/git-azure/blob/master/src/cli/commands/init.js#L81- could you also pull & merge against the latest
Reply to this email directly or view it on GitHub: https://github.com/tjanczuk/git-azure/pull/54#issuecomment-6615604
Reply to this email directly or view it on GitHub: https://github.com/tjanczuk/git-azure/pull/54#issuecomment-6615687