git-azure icon indicating copy to clipboard operation
git-azure copied to clipboard

Added support for 'env_variables' (raw using a CMD) & Windows Azure affinity group

Open johnnyhalife opened this issue 12 years ago • 4 comments

Fixes issue #53

johnnyhalife avatar Jun 27 '12 19:06 johnnyhalife

The support for env variables is done through set_env_var.cmd on the repo if it exists.

Support for affinityGroup is handled by git azure config (the same as other parameters)

NOTE: You should either define serviceLocation or affinityGroup but not both (affinityGroup takes precedence over serviceLocation)

johnnyhalife avatar Jun 27 '12 19:06 johnnyhalife

Thanks! A few comments in addition to the comments in the diff:

  • we should also add --affinityGroup as a command line option to git azure init. This can be done in src\cli\git-azure.js
  • we should also store the affinityGroup in git config after successful deployment as part of https://github.com/tjanczuk/git-azure/blob/master/src/cli/commands/init.js#L81
  • could you also pull & merge against the latest

tjanczuk avatar Jun 27 '12 21:06 tjanczuk

  1. sure will add it.
  2. I think we're already doing that. https://github.com/johnnyhalife/git-azure/blob/master/src/cli/commands/init.js#L92
  3. Will check, I think we're on edge but will check it.

On Wed, Jun 27, 2012 at 6:12 PM, Tomasz Janczuk < [email protected]

wrote:

Thanks! A few comments in addition to the comments in the diff:

  • we should also add --affinityGroup as a command line option to git azure init. This can be done in src\cli\git-azure.js
  • we should also store the affinityGroup in git config after successful deployment as part of https://github.com/tjanczuk/git-azure/blob/master/src/cli/commands/init.js#L81
  • could you also pull & merge against the latest

Reply to this email directly or view it on GitHub: https://github.com/tjanczuk/git-azure/pull/54#issuecomment-6615604

johnnyhalife avatar Jun 27 '12 21:06 johnnyhalife

Great, thanks. Re 2) you are right, I missed it.


From: johnny.halife [[email protected]] Sent: Wednesday, June 27, 2012 2:16 PM To: Tomasz Janczuk Subject: Re: [git-azure] Added support for 'env_variables' (raw using a CMD) & Windows Azure affinity group (#54)

  1. sure will add it.
  2. I think we're already doing that. https://github.com/johnnyhalife/git-azure/blob/master/src/cli/commands/init.js#L92
  3. Will check, I think we're on edge but will check it.

On Wed, Jun 27, 2012 at 6:12 PM, Tomasz Janczuk < [email protected]

wrote:

Thanks! A few comments in addition to the comments in the diff:

  • we should also add --affinityGroup as a command line option to git azure init. This can be done in src\cli\git-azure.js
  • we should also store the affinityGroup in git config after successful deployment as part of https://github.com/tjanczuk/git-azure/blob/master/src/cli/commands/init.js#L81
  • could you also pull & merge against the latest

Reply to this email directly or view it on GitHub: https://github.com/tjanczuk/git-azure/pull/54#issuecomment-6615604


Reply to this email directly or view it on GitHub: https://github.com/tjanczuk/git-azure/pull/54#issuecomment-6615687

tjanczuk avatar Jun 27 '12 21:06 tjanczuk