git-extras icon indicating copy to clipboard operation
git-extras copied to clipboard

Want an updated Makefile for BSD/Homebrew/non-root?

Open apjanke opened this issue 8 years ago • 8 comments

Hi folks,

I've just discovered git-extras through my work with Oh My Zsh and Homebrew and I'm digging it; I'd like to start using it regularly. I'm mainly an OS X/Homebrew user with a multi-user, multi-machine setup, and I'm running in to a few issues on this platform. I've got space for a weekend project. Would you be interested in a PR(s) that updated the Makefile and build process to do some or all of:

  • Make sure the whole build, including doco generation, works under BSD/OS X
  • Support relocating etc (#237)
  • Support disabling selected commands and suppressing prompting for alias conflicts (#442, #228)
    • (would make fully unattended, repeatable installs possible)
    • Remove man & doco for disabled commands, just to be tidy
  • Split the build and install into two steps, so you could build the commands (slurping in the library files) and run them inside the local source tree without having to install to the final destination (useful for iterating development)
  • Install the HTML and other format docs under /usr/share/doc (right now it looks like they're going under man, which should really only be for man-formatted stuff)
  • Unify makefile.msys with the main Makefile (#427)

Regardless, cheers for the good work.

apjanke avatar Oct 03 '15 01:10 apjanke

Waiting for it :smile:

spacewander avatar Oct 03 '15 09:10 spacewander

My only concern is that the build and install into two steps should be opt-in and not opt-out, so that the installation process doesn't become more complicated.

Otherwise, looking forward to seeing a PR from you. Thanks! :+1:

qw3rtman avatar Oct 18 '15 08:10 qw3rtman

Yeah, it'll be opt-in and transparent to users: make install will do the same thing as it does now, and do the build step internally as a dependency. This will just give developers the option to request just a local build with a make build or similar command.

apjanke avatar Oct 18 '15 14:10 apjanke

Sounds like a good idea to me! :smile:

qw3rtman avatar Oct 18 '15 18:10 qw3rtman