consolidate.js icon indicating copy to clipboard operation
consolidate.js copied to clipboard

memory leak with Nunjucks template

Open dail opened this issue 6 years ago • 2 comments

When i do stress testing, I have found an memory leak issue with Nunjucks's renderString method, which is called in this library. I have opened an issue in Nunjucks procect.

With the renderString method, we can't use relative path in template. When I replace it with render method of Nunjucks, no memory leak, relative path can also works correctly. I suggest use render method instead of renderString in this library.

dail avatar Aug 11 '17 09:08 dail

Is this still a problem?

edevil avatar Sep 27 '18 08:09 edevil

We have forked this repository for maintenance and released it under @ladjs/consolidate, see https://github.com/ladjs/consolidate.js. We have merged PR's and updated it for email-templates. Please click the "Watch" button to get notified of all releases at https://github.com/ladjs/consolidate.js. Thank you 🙏

Screen Shot 2023-06-08 at 3 05 12 PM

PR welcome at the new repo once new release is published today!

titanism avatar Jun 08 '23 20:06 titanism