TJ

Results 725 comments of TJ

nice you can change Atom's icon? didn't know that

ahh awesome :D

@saadq nice! :D

ahhh this is sort of a bug/gotcha, right now go-semver only supports `x.x.x` and `vx.x.x`, I think it's getting confused by two digits, we should definitely fix that though. Until...

sounds reasonable to me! I guess the only question is how many people would use it, but it shouldn't hurt

Hmm it worked fine for this project: https://github.com/tj/staticgen/blob/master/cmd/staticgen/main.go#L22, I haven't tested with others. I'm definitely down for exposing more variables by default, but I'd like to avoid configuration if possible....

@mblarsen yep same thing: ``` building: exit status 1: go: finding github.com/caddyserver/caddy v2.0.0 go: finding github.com/caddyserver/caddy v2.0.0 go: errors parsing go.mod: /home/go.mod:5: require github.com/caddyserver/caddy: version "v2.0.0" invalid: module contains a...

Hmm maybe the `@version` should be optional in these cases, looks a bit awkward haha

ahh darn, might not be a reasonable way around that since it's a Cloudflare limitation (without some enterprise package at least). #16 might be relevant since Caddy has binaries already,...

@yujunz yeah we'd probably have to time out a bit earlier in Go to have a chance to respond, but SGTM