TJ
TJ
LGTM other than the potentially superfluous Close
@johnwchadwick care to check it out? I don't use logentries
yep, cool. I'll tweak a few things and get that in tomorrow. We're missing comments and the style is a bit different than the others (they all use `New()` for...
Hmmm tough call, I feel like exposing `.finalize` would be a little gross, but I see what you mean. I think the part I dislike the most right now is...
Yeah I think that would be fine, I can't remember why I did it this way haha, maybe just a convenience thing but I'm down with that!
It's a little hacky due to how pkg/errors exposes the filename/lineno, but there's [support for pkg/errors](https://github.com/apex/log/blob/master/entry.go#L57) which may help a bit if you can use that. I'm not against it...
Something like: ```go // The HandlerFunc type is an adapter to allow the use of // ordinary functions as HTTP handlers. If f is a function // with the appropriate...
Seems like something that could maybe be delegated with a little util func, like `ctx = util.LogContext(ctx)` in the app somewhere adding those details
I was wondering similar with encoding/json and similar. I can see how it would get sketchy having nuanced differences between the two environments, but it could eliminate so much unnecessary...
Right yeah, I wasn't thinking about all of the reflection semantics.