axon icon indicating copy to clipboard operation
axon copied to clipboard

unix socket reconnect fails

Open datvong-wm opened this issue 6 years ago • 2 comments

On linux, call to connect socket.connect("unix:///home/mypath")

fails with

RangeError: "port" option should be >= 0 and < 65536: NaN
    at lookupAndConnect (net.js:970:13)
    at Socket.connect (net.js:945:5)
    at Socket.connect (net.js:904:37)
    at SubSocket.Socket.connect (/home/app/node_modules/axon/lib/sockets/sock.js:295:8)
    at Timeout._onTimeout (/home/app/node_modules/axon/lib/sockets/sock.js:280:12)

First time called, the port containing "unix:///home/mypath" is parsed so port="/home/mypath" https://github.com/tj/axon/blob/df2f5bb1637e39f1391dfd8f355db94f9b768e87/lib/sockets/sock.js#L251

    if (port.protocol == "unix:") {
      host = fn;
      fn = undefined;
      port = port.pathname;

On timeout and subsequent retry, port of "/home/mypath" will fail because protocol "unix://" has been stripped from port.

    setTimeout(function(){
      debug('%s attempting reconnect', self.type);
      self.emit('reconnect attempt');
      sock.destroy();
      self.connect(port, host);

datvong-wm avatar Jun 11 '18 23:06 datvong-wm

PR #150 is a fix for this issue.

datvong-wm avatar Jun 19 '18 00:06 datvong-wm

@datvong-wm nice!

METACEO avatar Jun 19 '18 03:06 METACEO