tison

Results 964 comments of tison

Seems a good first issue, if with the related code in OpenDAL posted.

> I do note a lack of tests? Doc tests cover most branches. I don't find a dedicated file to cover its cousin `sort_unstable`. If you can point me to...

> The examples can change at any time. And you didn't test, for example, the post-condition that all elements `..start` are less than or equal to the elements `start..end` and...

Pushed a new implementation. I'm writing tests but perhaps we'd have a new mod under `library/alloctests/tests/partial_sort` rather than patch the existing [library/alloctests/tests/sort/tests.rs](https://github.com/rust-lang/rust/blob/main/library/alloctests/tests/sort/tests.rs). Since the sort tests are heavily depending on...

> Pushed a new implementation. > > I'm writing tests but perhaps we'd have a new mod under `library/alloctests/tests/partial_sort` rather than patch the existing [library/alloctests/tests/sort/tests.rs](https://github.com/rust-lang/rust/blob/main/library/alloctests/tests/sort/tests.rs). Since the sort tests are...

Pushed some basic test cases at https://github.com/rust-lang/rust/pull/149318/commits/01bfcc05322896da4cbc24835aa61e244fa3e391. The existing sort tests have many assumptions, like `checked_sort` always sorts the whole range (for sure), and this helper is tightly coupled in...

cc @Amanieu as a libs-team member and ever touch the `compare` crate.

@the8472 Using these `Compare`/`PartialCompare` trait in collections would introduce more topics to discuss. I found a [previous discussion in IRLO](https://internals.rust-lang.org/t/pre-rfc-add-comparator-api-for-ordered-collections/15889). It seems to be no blocker for adding a new...

@the8472 IIUC the integration is possible. You can check binary-heap-plus linked above as an example. And the allocator-api show a way for evolution the generic of existing collections. HashMap also...