tison

Results 964 comments of tison

This is partially resolved by https://github.com/streamnative/pulsar-rs/pull/269. Keep open for a while since there are still several potential improvements can be made. See https://github.com/streamnative/pulsar-rs/pull/269#pullrequestreview-1382771811.

Sounds good. This is the first time I noticed this library.

> Can you add some tests? Sure. Perhaps following https://github.com/helm/helm/pull/30553/. It's midnight for me now. I may handle it later.

@benoittgt Thanks for the cross ref. Will do once this patch gets merged. Not sure if you know some active helm maintainer that can help here.

@robertsirc may we follow up for merging this patch?

@scottrigby @robertsirc I think we have reached consensus on this patch. Hopefully we won't leave it long pending and even conflict later.

@fdncred Yeah. Do you have some information here to investigate more? Anyway, it's hidden behind reedline's API. I don't know how the error variant can be hit here.

Well. I have no background how "asking for cursor position" can hang or fail :P

@seanmonstar Now we're on base64 v0.21.7 while the latest version is v0.22.1. Is it desired to submit a patch for upgrading? If so, I can take care of it.

> MediaRange Does this something have a standard (RFC)? I don't find one. > Expressive matching I have a use case like: ```rust if content_type.type_() != mime::APPLICATION { return Err(make_error().into());...