tison

I'm testing on @jmhain's branch https://github.com/sqlparser-rs/sqlparser-rs/pull/1290 on the subscript fixes and encounter the following new API breaks: ``` Compiling datafusion-sql v38.0.0 (/Users/tison/Brittani/arrow-datafusion/datafusion/sql) error[E0599]: no variant named `ArrayIndex` found for enum...

I've handled all other trivial new ASTs. But how to migrate `SQLExpr::ArrayIndex` to `SQLExpr::Subscript` still need some time to work out. Perhaps @jmhain can take a look and patching this.

Ensure all the sqllogictests passed without the array index cases: Details ``` ### Array index ## array[i] # single index with scalars #1 (positive index) query IRT select make_array(1, 2,...

@alamb Thank you and cool! I'll update this PR once sqlparser released a 0.47.

@alamb there is even a new breaking change at https://github.com/sqlparser-rs/sqlparser-rs/pull/1272: ``` error[E0277]: the trait bound `Arc: From` is not satisfied --> datafusion/sql/src/expr/mod.rs:578:74 | 578 | DataType::Timestamp(TimeUnit::Nanosecond, Some(time_zone.into())), | ^^^^ the...

Pushed some commit to catch up new sqlparser-rs commits. Let's see.

Since we're on the sqlparser-rs main branch now, I'd consider this patch as ready to merge. But of course it's better to have a new release to sqlparser-rs and we...

Window specific test failed. I don't have a windows env to debug ... ``` test cli_quick_test::case_4_set_batch_size ... FAILED failures: ---- cli_quick_test::case_4_set_batch_size stdout ---- thread 'cli_quick_test::case_4_set_batch_size' panicked at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6\library\core\src\ops\function.rs:250:5: Unexpected stdout,...

@alamb Thanks for your review and follow-up! @jmhain Thanks for your help :D

> Hello, @tisonkun I hope you're doing well! Just a friendly reminder that my submitted PR is still awaiting merge. If you have some time, please merge it as soon...