tison

Results 964 comments of tison

Almost looks good. But one new issue here: the rewrite process cannot properly analyzes `var` variables. That is, I define a variable in type `RaftClientReply` using `final var reply =...

> I'm not sure what you're referring to about combining style. I mean the `styles` and `recipes` here: ```xml com.netflix.eureka.Style org.openrewrite.java.format.AutoFormat org.openrewrite.java.OrderImports org.openrewrite.java.RemoveUnusedImports ```

@traceyyoshima Sorry for the late response: I'm verifying it now and answer your questions above.

> I don't see any code like that in the sample project It's when you run the rewrite plugin locally, you will find an extra import occurs. > Were the...

... Today I rerun the plugin with config: ```xml org.openrewrite.maven rewrite-maven-plugin ${maven-rewrite-plugin.version} com.netflix.eureka.Style org.openrewrite.java.format.AutoFormat ``` But it generates strange diffs on indents and whitespace: ```diff diff --git a/zeronos-client/src/test/java/io/korandoru/zeronos/client/ZeronosClientTest.java b/zeronos-client/src/test/java/io/korandoru/zeronos/client/ZeronosClientTest.java index...

@waynexia it seems that: ```rust /// system_catalog table id pub const SYSTEM_CATALOG_TABLE_ID: u32 = 0; /// scripts table id pub const SCRIPTS_TABLE_ID: u32 = 1; ``` these two consts are...

@IDJack This patch looks good to me. Can you fix the DCO requirement? I can approve and schedule a merge once it's done.

Closed by https://github.com/tikv/raft-rs/pull/440.

@Xuanwo I guess OpenDAL provides this function out-of-the-box? It seems should be in OpenDAL's scope. @MichaelScofield do all our access to object store fall into OpenDAL? I wonder if we...