xiejialong

Results 65 comments of xiejialong

https://github.com/xtermjs/xterm.js/blob/fb2c39cb5748e071e0a1ed49824590aafd45e65e/src/browser/renderer/shared/CellColorResolver.ts#L146-L148 An extra 3 bits will solve the problem...

@jerch Variant starts from here #4349

![first](https://github.com/xtermjs/xterm.js/assets/48614781/b26e26c1-a068-49ac-9e17-718669f37e84) :yum: Code not processed I'll take care of it these days. It also expands the memory footprint and requires optimization. Testing, etc.....

@Tyriar Using underlineOfferset,I want to migrate from ext related to underline,But there were some significant changes. Also changed the Map to 5 keys.Look at those that need to be adjusted.

fontSize 36 ![36-1](https://github.com/xtermjs/xterm.js/assets/48614781/ad869159-3597-4526-ac03-f89e4cb6c6d5) ![36-2](https://github.com/xtermjs/xterm.js/assets/48614781/40752a88-df80-4608-ac27-c8423c7a70bd)

https://github.com/xtermjs/xterm.js/blob/fb2c39cb5748e071e0a1ed49824590aafd45e65e/addons/addon-search/src/SearchAddon.ts#L507 This cost is not small either.

Normal on xterm demo, slightly lagging in vscode.

I see if there is anything I can do on the demo to facilitate subsequent verification. 😀

Uncertain if it will have an impact on vscode. 😨

@TalZaccai I will adjust the variable names later...