Tihomir Krasimirov Mateev

Results 283 comments of Tihomir Krasimirov Mateev

Hey @wuliao6688, hiredis-py requires Python 3.7+ as per the documentation.

Hey @jigneshmpatel , > Initially, I used to have a following dependencies defined in pom.xml unfortunately it is very hard to give out a recommendation on this, as it is...

Let me know if you have an issue with this approach, closing this for now

> Generally, we attempt to be as light-weight as possible. `RedisClusterNode.slots` is designed to be `null` so it would make sense to update both, the constructor of `RedisClusterNode` to expect...

> Allocation of `BitSet` uses up a bit of memory and CPU, hence we resorted to `null`. If you want to follow the null object pattern, then introducing a `Slots`...

> I confirmed that my pull request failed during the integration tests. It seems like the failure is related to `HashCommandIntegrationTests`, which doesn’t seem to be directly connected to the...

> There was a change in the redis/redis codebase that broke the tests, it has been since fixed. I've started the pipeline again. Actually - my bad - you will...

Hm something seems off to me, your change should not span 85 files I think something went wrong with the merge

> Hm something seems off to me, your change should not span 85 files I think something went wrong with the merge There, I fixed it :)