Tihomir Krasimirov Mateev
Tihomir Krasimirov Mateev
> Ah, I understand it and I agree with you. Good explanation! If it is not an urgent issue, and it is a good first issue for non-contributors to contribute...
Pushing this for 6.6.0 for now, as we want 6.5.1 released in December with some critical fixes
Many thanks to @psw0946 for the contribution!
Hey @jabolina , do you mind extending the `StringCommandIntegrationTests` to showcase the issue you are fixing?
> @tishun, I've extended the class but didn't push yet. Which server version does the CI run with? So I can check the tests. Depending on the version, the tests...
> IIUC, the spec does not make assumptions about the order of elements in the map. It could receive the keys in any order. However, I believe Redis always returns...
> I added a second commit to the PR. It re-works some of the StringMatchResultOutput a little and registers into the OutputRegistry. This change removes the boolean in the constructor...
> Yeah, right on point 🎯 > > This approach in steps makes more sense. We can close this PR and handle the issues in increments. If any of the...
From an API perspective there are multiple ways where we could wrap the commands together. So this part is not a challenge itself. The problem comes when we decide to...
Hey @thachlp , there is a number of tests that fail after this change, most likely because they do not expect these timeout options to be set by default. Could...