Sebastian Cohnen
Sebastian Cohnen
This looks great! I've just checked this against our website and it works as expected.
I just realised, that this does not seem to work with assets outside of the image path. That might be our fault, but the asset digest logic works fine... Need...
I'm trying to wrap my head around another change: I also noticed that you've dropped `base_url`. Is there a way to ensure that attributes like `og:url` and `og:image` are full,...
For images actually, one can set `activate :asset_host, host: "https://example.com"` and this branch will do the right thing for the image. But that does not seem to work for `og:url`.
I'm not that familiar with middleman internals, but it looks like `Middleman::Util.url_for(app, obj)` takes an option called `relative`. Maybe this can be used somehow?
HTTP headers are case-insensitive ([RFC9110 Sec 5.1 Field Names](https://datatracker.ietf.org/doc/html/rfc9110#section-5.1)). I was under the assumption that Faraday already does header name normalisation, but maybe that's not the case, or there is...
With webrick as a direct dependency, it is kind of a nice out of the box experience currently: You only need to install rackup and you are ready to go....
Sorry for the ping, @tcuongd, but there are so many issues for this issue and several open PRs to fix it… maybe we can get this one in somehow? Unless...
Thanks for merging, @WardBrian. Is there any chance to get a release cut soonish? I couldn't find a milestone or something and it has been a while since the last...
Fixed in https://github.com/facebook/prophet/pull/2592