Christian Heimes

Results 184 comments of Christian Heimes

Packaging's version parser parses Rust's beta versions correctly, e.g. ``rustc 1.55.0-beta.1 (739f8f0a8 2021-07-28)`` is recognized as ``1.55.0b1``. ``` >>> packaging.version.Version("1.55.0-beta.1") < packaging.version.Version("1.55") True >>> packaging.version.Version("1.55.0-beta.1") < packaging.version.Version("1.55.0-alpha.1") False >>> packaging.version.Version("1.55.0-beta.1")...

> The error message raised from get_rust_version if the compiler is not suitable will now use packaging syntax when it formats min_version on utils.py line 73. I think it'd potentially...

Which ``MANIFEST.in`` do you prefer, ``` graft examples recursive-include tests *.py ``` or ``` recursive-include examples *.py *.rs *.toml *.ini *.cfg *.sh *.lock *.in *.txt *.html *.md *.yml Dockerfile recursive-include...

Clarification: I'm not a lawyer and I don't feel qualified to write a DevGuide section for the problem. The bullet points in my initial comment are things I know or...

The changeset broke wasm32-emscripten builds. ``` $ ./Tools/wasm/wasm_build.py emscripten-node-dl-debug $ cd builddir/emscripten-node-dl-debug/ $ $ make test TESTOPTS="test_capi" ... 0:00:03 load avg: 3.51 [1/1/1] test_capi crashed (Exit code 1) warning: unsupported...

The clear function signature is incorrect. The PR defines it as `static void heapmanaged_clear` but it must be `static int heapmanaged_clear`. I'm also getting warnings on X86_64: ``` comparison of...

Petr takes care of ``parts.h`` in https://github.com/python/cpython/pull/95992

I have replied to you on BPO twenty minutes after you have opened the bug in 2018, https://bugs.python.org/issue32882#msg312408 tl;dr the improve is a good idea in general, but the API...