David

Results 279 comments of David

No one is working on this issue. I'm happy to review if the PRs are easily reviewable :)

I think the core of j2html should be dependency free, so I would provide the option to configure your own minifier (through an interface), and provide this as a separate...

Hmm. There appears to be a `getNumChildren()`, but no `getChildren()`. Would you like to submit a PR?

You didn't tag anyone, so I'll answer just in case. I don't think there is anything preventing them being merged (except the conflicts in #152), but I already feel like...

Just ping me when you want me to release. Is the master branch back to being non breaking now?

@obecker @sembler say the word and I'll release 1.5.0.

I ran into `POM file pom.xml specified the -f/--file command-line argument does not exist` when trying to release, I guess it's related to moving the library into a subdir. Edit:...

@sembler @obecker 1.5.0 is out, great job both of you! I found one small breaking change when updating the website to 1.5.0: ![image](https://user-images.githubusercontent.com/1521451/121821901-433d7e00-cc9c-11eb-9236-055aa8a7144b.png)

This is a cool idea, I like it! A few thoughts: * These new dependencies should not be required by the final jar * Would make sense to create one...

Fair enough, we can see how long it becomes before splitting it up. I thought you meant we would call the generator using a maven plugin, but creating a plugin...