go-gst icon indicating copy to clipboard operation
go-gst copied to clipboard

Published 20 hours ago • verified publisher icon tinyzimmer

Add support for gstreamer 1.16 by putting 1.18 specific stuff behind a build tag

Open nielsavonds opened this issue 3 years ago • 4 comments

For backward compatibility, when building without any build tags, the latest gstreamer version is assumed.

nielsavonds avatar Apr 19 '22 09:04 nielsavonds

Thanks for doing this, it was desperately needed. I'll want some time to play with it, but I'll get back to you.

tinyzimmer avatar Apr 19 '22 17:04 tinyzimmer

No problem! Let me know if anything needs to be changed or if you think it makes more sense to put things behind a gst118 flag instead.

nielsavonds avatar Apr 19 '22 17:04 nielsavonds

Sorry for the delay. This looks good and works really well. The only thing I'm thinking is adding a couple lines to the README about how to use the tags. Not super critical though. I could do that later.

tinyzimmer avatar Jun 10 '22 16:06 tinyzimmer

@nielsavonds please recreate this PR for https://github.com/go-gst/go-gst (where future development of the bindings will take place) if you think it is necessary.

This also raises the question posed in https://github.com/go-gst/go-gst/issues/13#issuecomment-1691256106 for which gstreamer version do need support. Since this PR was created some time passed and gstreamer 1.22.0 is widely available. Is this PR still relevant?

RSWilli avatar Aug 24 '23 20:08 RSWilli