tinymce-angular icon indicating copy to clipboard operation
tinymce-angular copied to clipboard

fix: cursor jumping at the beginning

Open davidediak opened this issue 1 year ago • 9 comments

https://github.com/tinymce/tinymce-angular/issues/321

davidediak avatar Feb 07 '24 13:02 davidediak

Sure, I fixed your tests and also added a test related to my fix. Please feel free to contribute to the tests if needed, I'm not really familiar with your internal testing lib.

davidediak avatar Mar 28 '24 13:03 davidediak

Ah thank you. #367 also has a fix for this failing test. Once that's merged I'll rereview

danoaky-tiny avatar Apr 04 '24 06:04 danoaky-tiny

Hi! Is there any plan to incorporate this fix soon? Thank you

constanzaccg avatar May 07 '24 10:05 constanzaccg

@davidediak This needs a merge from main. Just to do with the tests, won't need much change from you.

danoaky-tiny avatar May 07 '24 22:05 danoaky-tiny

@danoaky-tiny sure, done.

davidediak avatar May 08 '24 10:05 davidediak

Hello davidediak,

Thank you for your code contribution, in order for Tiny Inc to accept your code, we will need permission to use your code contribution, this can be done through the Tiny Contributor License Agreement (Tiny CLA). Please contact [email protected] to sign the Tiny CLA agreement.

EkimChau avatar May 08 '24 22:05 EkimChau

@EkimChau you have my permission to use my code, given the fact that I spent time fixing the bug and did open a PR. I have no intention of proving your company with my personal data.

davidediak avatar May 13 '24 08:05 davidediak

This is clearly stated in the contributing guide. We don't have an automated system for it at the moment. https://github.com/tinymce/tinymce-angular/blob/5bcfde80e8c5cb78b806d14c5c9e11d1af2c3471/CONTRIBUTING.md?plain=1#L8

The CLA protects us, our open-source community and our customers from the distribution of unauthorised code. It's non-negotiable, sorry.

TheSpyder avatar May 13 '24 10:05 TheSpyder