tinyhttp icon indicating copy to clipboard operation
tinyhttp copied to clipboard

Fix: Issue #351 default server host compatibility with IPv6

Open Barnabas opened this issue 3 years ago • 1 comments

Closes #351 by un-defining the default server host name and adds a new test which passes on dual-stack machines.

Sadly, this may not be testable on GitHub due to actions/virtual-environments#668.

Barnabas avatar Mar 25 '22 20:03 Barnabas

CI seems to fail

probably worth skipping IPv6 tests?

v1rtl avatar Apr 08 '22 07:04 v1rtl

any update on this PR?

aarontravass avatar May 08 '23 15:05 aarontravass

@aarontravass I think GitHub actions don't support IPv6 so I guess I'll just manually remove the failing test and will merge this

v1rtl avatar May 09 '23 16:05 v1rtl

@aarontravass I think GitHub actions don't support IPv6 so I guess I'll just manually remove the failing test and will merge this

How about testing ipv6 only if run on non github ci/cd runners? Actions has some default variables that you can utilize - https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables

For example

const isGithubAction = Boolean(process.env.GITHUB_ACTION)
const agent = new Agent({ family: isGithubAction ? 4 : 6 })

aarontravass avatar May 09 '23 20:05 aarontravass

@aarontravass good idea, feel free to extend this PR and update the tests

v1rtl avatar May 10 '23 11:05 v1rtl